Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NB2: Simulate crop cycle #105

Open
WeirdCxychen opened this issue Jan 18, 2024 · 8 comments
Open

NB2: Simulate crop cycle #105

WeirdCxychen opened this issue Jan 18, 2024 · 8 comments

Comments

@WeirdCxychen
Copy link

Hi, here is another issue. Sorry to interrupt you again:
When I ran the NB2, the "Simulate crop cycle" part told me that "name 'L6a' is not defined", but before this part, it could run successfully.
Could you please tell me how that happened? Here is the issue below:
1705545699231

@NokuzaSezo97
Copy link
Collaborator

Hi @WeirdCxychen,

Could you do these checking?

  1. Are you simulation perennial crop or annual crop? Usually L** is used in annual crop-specific rule excel sheet while N** is used for perennials. (Refer to crop specific rule setting notation differences in sample crop-specific rule sheet).
  2. In your input crop parameter setting, is your selected crop name's column "annual/perennial flag 0 or 1. (0 for annual, 1 for perennial).

I suspect there's something wrongly set up, causing this error. Still, if the error persist, you can send me your sample NB2 notebook, excel sheet of crop parameters and crop-specific rule.

Regards,

Swun Wunna Htet

@WeirdCxychen
Copy link
Author

@NokuzaSezo97,

Thank you so much for your reply.

After checking my parameter in NB2, I found that if in the "Setting up the thermal screening parameters (Optional)", "aez.setThermalClimateScreening(tclimate, no_t_climate=[2,6,7,8,9,10,11,12])" matches with the sample code, it could be run successfully, but in my own study area, using this parameter may not be suitable.
Could you please tell me why the sample code was chosen 2, 6, 7, 8, 9, 10, 11, 12? And whether I should choose the same amount as the sample?
Here is the issue below:
1705557877185

Regards,

Xinyue Chang

@WeirdCxychen
Copy link
Author

Here are my Thermal Climate zone and issue part:
image

1705558053396

@NokuzaSezo97
Copy link
Collaborator

Hi @WeirdCxychen,

After checking maize parameters and your thermal climate map, I found out that the maize in example data sheet is for tropical regions. So, obviously, running tropical maize in temperate regions won't be suitable. I would suggest going to GAEZ Appendices where temperate maize thermal climate suitability classes are mentioned and modify in the no_t_climate list. Note that if you're running maize in temperate regions, make sure all the crop parameters are specifically for temperate regions.

Regards,

Swun Wunna Htet

@WeirdCxychen
Copy link
Author

Hi @NokuzaSezo97,

I'm glad your suggestion enlightened me a lot. The no_t_climate list can be found in Appendix 4-6.1, but after l changed the list to temperate maize, it still noticed the same error "name 'L6a' is not defined".
sorry for interrupting you, and thank you for your time~

Here is the issue and my data below:
1705564714456
1705564769223
1705564857975
cxy_test.zip

@WeirdCxychen
Copy link
Author

And another data package:
cxy_test_1.zip

@NokuzaSezo97
Copy link
Collaborator

Hi @WeirdCxychen,

In your excel sheet, the annual/perennial flag is set to 1 (which is for perennial, and mentioned earlier in the comment (#105 (comment)). That's why you got an error. Please set to 0 (annual) flag, and rerun it; everything should be ok.

Regards,

Swun Wunna Htet
image

@WeirdCxychen
Copy link
Author

Thank you so much for your checking and advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants