tidying up & attempted layergroup creation #75
Conversation
|
Hi @Zeitsperre , thank you for taking time to review the PR. I will make necessary fixes now and reopen. |
|
First of all, Thank you very much @jeafreezy for your valuable contribution to this package. Also thank you very much @Zeitsperre for your quick review. Before merging it into the master branch, I will also review the changes. I will manage some time this week. |
|
Sounds good.! Thanks for the great work @iamtekson! |
| @@ -70,7 +90,7 @@ def get_manifest(self): | |||
|
|
|||
| def get_version(self): | |||
| """ | |||
| Returns the version of the geoserver. | |||
| Returns the version of the geoserver as JSON. It contains only the details of the high level components: GeoServer, GeoTools, and GeoWebCache | |||
| """ | |||
| try: | |||
| url = "{}/rest/about/version.json".format(self.service_url) | |||
There was a problem hiding this comment.
Please remove the rest parameter from url. I think it is needed to check for all the requests.
| def get_layer(self, layer_name: str, workspace: Optional[str] = None): | ||
| """ | ||
| Returns the layer by layer name. | ||
| """ | ||
| try: | ||
| url = "{}/rest/layers/{}".format(self.service_url, layer_name) | ||
| url = "{}/layers/{}".format(self.service_url, layer_name) | ||
| if workspace is not None: | ||
| url = "{}/rest/workspaces/{}/layers/{}".format( |
There was a problem hiding this comment.
Same here, Need to remove rest from url.
| ): | ||
| self.service_url = service_url | ||
| self.username = username | ||
| self.password = password | ||
|
|
||
| # private request method to reduce repetition of putting auth(username,password) in all requests call. DRY principle | ||
|
|
||
| def _requests(self, method: str, url: str, **kwargs) -> requests.Response: |
There was a problem hiding this comment.
This is very useful. We can integrate this method in the next PR/release.
|
Thanks for the review @iamtekson , will implement the corrections and attempt other methods of the layer group |
In an attempt to work on issue 64, I wrote a function to handle layergroup creation.
There are a few TODOs which highlighted in the code because Implementing some will change the location of some functions.
Also, I didn't attempt 2,3,4 in the issue because I want to get a review on this before I attempt other functions.
I look forward to your response.