Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPrecision should create a string, not a float, in the JSON output #3

Closed
DougBurke opened this issue Jul 10, 2019 · 1 comment
Closed

Comments

@DougBurke
Copy link
Contributor

I am hoping this is an error in the Vega-Lite 3.3.0 specification - see vega/vega-lite#5190 for a discussion - but PPrecision should be generating a string rather than a float.

(I've finally integrated your test suite into hvega, where I generate the JSON for each test and then compare it against the checked-in version to ensure the output hasn't changed; it means I have a bunch of JSON files I can easily validate against the Vega Lite schema, which finds the odd strange case like this)

@jwoLondon
Copy link
Member

Thanks for raising this over on Vega-Lite. Looks like it will be solved in the next VL release vega/vega-lite#5191 and the elm-vegalite and hvega specs can remain as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants