-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expected precision field of Projection to be a number not a string in VegaLite 3.3.0 schema #5190
Comments
Looks like Vega expects strings: https://vega.github.io/vega/docs/projections/ |
I wonder why? Oh well, thanks for checking. |
Well, could be a bug in Vega. Could you check? |
The Vega schema says it's number: https://github.com/vega/vega/blob/master/packages/vega-schema/src/projection.js#L20. |
Sorry - was in a meeting so couldn't investigate further. |
No problem. Again, thanks for catching and reporting the issue! I fixed it in #5191. |
Even though version 3.3.0 of the Vega-Lite schema says that the precision field is a string, this is an error, and it should be a number. I have therefore reverted the previous change during 0.4.0.0 development that wrote out a string rather than number. See vega/vega-lite#5190
I was surprised to find the
precision
field ofProjection
has a type ofstring
and notnumber
:https://github.com/vega/schema/blob/master/vega-lite/v3.3.0.json#L8971
The text was updated successfully, but these errors were encountered: