Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct projection precision's type to number (not string) #5191

Merged
merged 1 commit into from
Jul 14, 2019

Conversation

domoritz
Copy link
Member

Fixes #5190

@domoritz domoritz requested review from kanitw and jheer July 10, 2019 15:39
@domoritz
Copy link
Member Author

Related Vega PR: vega/vega#1871

@kanitw kanitw changed the title fix: precision is a number, not a string fix: correct projection's precision type to number (not string) Jul 14, 2019
@kanitw kanitw changed the title fix: correct projection's precision type to number (not string) fix: correct projection precision's type to number (not string) Jul 14, 2019
@kanitw kanitw changed the title fix: correct projection precision's type to number (not string) fix: projection precision's type (number, not string) Jul 14, 2019
@kanitw
Copy link
Member

kanitw commented Jul 14, 2019

Please name your PR / commit message so it reads like an imperative sentence (e.g., "fix: precision is a number, not a string" -> "fix: correct projection precision's type to number (not string)"

@kanitw kanitw changed the title fix: projection precision's type (number, not string) fix: correct projection precision's type to number (not string) Jul 14, 2019
@kanitw kanitw changed the title fix: correct projection precision's type to number (not string) fix: correct projection precision 's type to number (not string) Jul 14, 2019
@kanitw kanitw changed the title fix: correct projection precision 's type to number (not string) fix: correct projection precision's type to number (not string) Jul 14, 2019
@kanitw kanitw merged commit 9951f52 into master Jul 14, 2019
@kanitw kanitw deleted the dom/projection-precision branch July 14, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expected precision field of Projection to be a number not a string in VegaLite 3.3.0 schema
2 participants