-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hackathon improvements #8
Conversation
CI fails are that tests have not been blacked, yet. |
have done so |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #8 +/- ##
===========================================
+ Coverage 59.90% 72.22% +12.31%
===========================================
Files 2 2
Lines 222 252 +30
Branches 48 55 +7
===========================================
+ Hits 133 182 +49
+ Misses 72 41 -31
- Partials 17 29 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I can judge looks good (did not review the notebooks).
dims += ["geometry"] | ||
coords["geometry"] = [i for geom, i in geoms_idxs] | ||
dims += [self.idxkey] | ||
coords[self.idxkey] = [self.tags[i][1] for geom, i in geoms_idxs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not deep enough in the code to understand the significance of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it simply renames the key for shapes to the original name, so instead of having a coord named "geometry", it is now "iso_a3" or whatever was in the original shape file
Co-authored-by: Jonas Hörsch <coroa@posteo.de>
Co-authored-by: Jonas Hörsch <coroa@posteo.de>
Thanks @coroa ! |
This adds the capability to put panel data on multi-layer rasters and calculation of latitude-indexed grid cell areas