Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackathon improvements #8

Merged
merged 15 commits into from
Apr 5, 2023
Merged

hackathon improvements #8

merged 15 commits into from
Apr 5, 2023

Conversation

gidden
Copy link
Owner

@gidden gidden commented Mar 28, 2023

This adds the capability to put panel data on multi-layer rasters and calculation of latitude-indexed grid cell areas

@gidden gidden changed the title add weighted dataframe to raster hackathon improvements Mar 29, 2023
@gidden gidden requested a review from coroa March 29, 2023 14:49
@coroa
Copy link
Collaborator

coroa commented Mar 29, 2023

CI fails are that tests have not been blacked, yet.

@gidden
Copy link
Owner Author

gidden commented Mar 29, 2023

have done so

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #8 (752b517) into main (40ad146) will increase coverage by 12.31%.
The diff coverage is 65.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main       #8       +/-   ##
===========================================
+ Coverage   59.90%   72.22%   +12.31%     
===========================================
  Files           2        2               
  Lines         222      252       +30     
  Branches       48       55        +7     
===========================================
+ Hits          133      182       +49     
+ Misses         72       41       -31     
- Partials       17       29       +12     
Impacted Files Coverage Δ
src/ptolemy/raster.py 71.42% <64.10%> (+12.82%) ⬆️
src/ptolemy/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@coroa coroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I can judge looks good (did not review the notebooks).

src/ptolemy/raster.py Outdated Show resolved Hide resolved
src/ptolemy/raster.py Outdated Show resolved Hide resolved
dims += ["geometry"]
coords["geometry"] = [i for geom, i in geoms_idxs]
dims += [self.idxkey]
coords[self.idxkey] = [self.tags[i][1] for geom, i in geoms_idxs]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not deep enough in the code to understand the significance of this change.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it simply renames the key for shapes to the original name, so instead of having a coord named "geometry", it is now "iso_a3" or whatever was in the original shape file

src/ptolemy/raster.py Outdated Show resolved Hide resolved
gidden and others added 3 commits April 5, 2023 13:50
Co-authored-by: Jonas Hörsch <coroa@posteo.de>
Co-authored-by: Jonas Hörsch <coroa@posteo.de>
@gidden
Copy link
Owner Author

gidden commented Apr 5, 2023

Thanks @coroa !

@gidden gidden merged commit 32a7a93 into main Apr 5, 2023
@gidden gidden deleted the w_df_to_r branch April 5, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants