Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typing warning from mypy involving httpx #125

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Fix a typing warning from mypy involving httpx #125

merged 3 commits into from
Jun 4, 2020

Conversation

brettcannon
Copy link
Collaborator

Closes #123

caseyduquettesc
caseyduquettesc reviewed Jun 3, 2020
View reviewed changes
gidgethub/httpx.py Outdated Show resolved Hide resolved
@brettcannon @caseyduquettesc
Update gidgethub/httpx.py
c9db5b8 
Thanks to @caseyduquettesc for doing something faster than my laziness did. :)

Co-authored-by: Casey <casey.duquette@snapchat.com>
@brettcannon brettcannon merged commit b236be1 into master Jun 4, 2020
@brettcannon brettcannon deleted the fix-mypy-httpx-warning branch June 4, 2020 20:37
@brettcannon
Copy link
Collaborator Author

Thanks, @caseyduquettesc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyduquettesc caseyduquettesc caseyduquettesc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing mypy linting
2 participants
@brettcannon @caseyduquettesc