Merge pull request #361 from giggsey/issue-360

Fix bug when calling isPossibleNumber with string, null
giggsey · Jan 21, 2020 · e420348 · e420348
2 parents 1ec1059 + 5c0b80b
commit e420348
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/PhoneNumberUtil.php b/src/PhoneNumberUtil.php
@@ -3475,7 +3475,7 @@ public function isMobileNumberPortableRegion($regionCode)
      */
     public function isPossibleNumber($number, $regionDialingFrom = null)
     {
-        if ($regionDialingFrom !== null && is_string($number)) {
+        if (is_string($number)) {
             try {
                 return $this->isPossibleNumber($this->parse($number, $regionDialingFrom));
             } catch (NumberParseException $e) {

diff --git a/tests/Issues/Issue360Test.php b/tests/Issues/Issue360Test.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace libphonenumber\Tests\Issues;
+
+use libphonenumber\PhoneNumberUtil;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Test that you can not pass a string and null to isPossibleNumber
+ * @see https://github.com/giggsey/libphonenumber-for-php/issues/360
+ * @package libphonenumber\Tests\Issues
+ */
+class Issue360Test extends TestCase
+{
+    public function testNullRegion()
+    {
+        $this->assertTrue(PhoneNumberUtil::getInstance()->isPossibleNumber('+441174960123', null));
+    }
+}