Use self.encoding when calling Buffer.toString()

This is a bug resulting in getting UTF-8 mangled data in a callback when explicitly setting an encoding to 'ascii' or 'binary'.
gijs · Aug 10, 2012 · 7adc5a2 · 7adc5a2
1 parent 820af58
commit 7adc5a2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/main.js b/main.js
@@ -618,7 +618,7 @@ Request.prototype.start = function () {
             if (self.encoding === null) {
               response.body = body
             } else {
-              response.body = body.toString()
+              response.body = body.toString(self.encoding)
             }
           } else if (buffer.length) {
             response.body = buffer.join('')

diff --git a/tests/test-body.js b/tests/test-body.js
@@ -30,6 +30,11 @@ var tests =
     , encoding: null
     , expectBody: new Buffer("TESTING!")
     }
+  , testGetEncoding :
+    { resp : server.createGetResponse(new Buffer('efa3bfcea9e29883', 'hex'))
+    , encoding: 'hex'
+    , expectBody: "efa3bfcea9e29883"
+    }
   , testGetJSON :
      { resp : server.createGetResponse('{"test":true}', 'application/json')
      , json : true