Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prelude create an empty _macro_ standalone #132

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

gilch
Copy link
Owner

@gilch gilch commented Oct 17, 2021

defmacros after prelude don't create the _macro_ namespace, because one was already detected at compile time. However, if Hissp isn't installed, the resulting Python should stand alone. prelude silently ignores the import error and doens't bother creating _macro_ at runtime in that case, but that doesn't correct the defmacros which still expand as if _macro_ exists. I've adjusted prelude to create an empty _macro_ namespace regardless, and then only populate it if it can import it from Hissp.

defmacro only makes one if it wasn't present at compile time
@gilch gilch merged commit 3278634 into master Oct 18, 2021
@gilch gilch mentioned this pull request Jan 16, 2022
@gilch gilch deleted the standalone-prelude branch February 12, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant