-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for loading browser extensions #83
Comments
Thank you, I applied the suggested changes but I did not change |
Thanks! Can confirm that overriding the That iframe issue is a bit worrying, maybe I'll have to make using the extension optional. Let's see. |
For the record, I've looked at what's wrong with using |
For the record, the frame issue is fixed in the version |
It does work now, thanks for following up on that. In general, using single-file with the new headless mode seems to work very well, haven't observed any other issues so far. |
@sissbruecker Thank you for the feedback |
One thing I'd like to be able to do is run single-file together with a Chrome extension like uBlock Origin, so that:
Traditionally running extensions in headless Chrome was not possible, however somewhat recently a new headless mode was introduced that allows you to do pretty much anything you can do with a headful (?) Chrome instance, such as running extensions: https://developer.chrome.com/docs/chromium/new-headless
Adding support for this would require two configuration options:
--headless=new
instead of--headless
--disable-extensions
browser arg that single-file applies by defaultI did try patching single-file-cli with these changes, and was able to get the extension loaded (requires an up-to-date Chromium as well). While I can deploy my app with a patched version of single-file, it would be great if this could be added to the core. I'm up for contributing these changes if we can align on an API / specific option naming.
The text was updated successfully, but these errors were encountered: