Align --browser-server argument naming with its expected usage #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run the Single File CLI against an external browser lead me to finding this issue:
browserRemoteDebuggingURLis not configured as a possible argument in the CLI, and by the current translation from argument name to and attribute ofoptionsit could never be named with capital URLOn the other hand, the
browserServerwas defined as an argument but wasn't being used anywhere in the codeI might have misunderstood the intentions of the two attributes/arguments and the differences between them but thought I'd suggest this fix to allow others to use external browsers
Solves #93