Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If --message is not specified, prompt for it when it is needed #37

Closed
giltayar opened this issue Jan 9, 2021 · 0 comments
Closed

If --message is not specified, prompt for it when it is needed #37

giltayar opened this issue Jan 9, 2021 · 0 comments
Labels

Comments

@giltayar
Copy link
Owner

giltayar commented Jan 9, 2021

So that --dry-run (and others) can be executed without --message.

The idea is this: in command-build.js, if message is undefined, then wait for the execution of the during phase, and just before it, ask for the message (using the inquirer package from NPM) and update the options.

We're doing it before the "during" phase and not the after phase, because some jobs need the option during the during phase (for example, Roundforest's deploy job.

@giltayar giltayar added feature good first issue Issue for beginners labels Jan 9, 2021
giltayar added a commit that referenced this issue May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant