-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initcontainers support #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Few formatting comments and a question on what will happen if the initContainer
does not contain a command
.
- it: Should set command | ||
set: | ||
initContainers: | ||
- command: "while true; do date; sleep 2; done && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase uses the following format for multiline strings:
mystring: |
this
is
a multilline
i was surprised to see this working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes first i was doing it as multiline string
, then i found that you are using qoute
on the command for the main container, it was more convenient for me with less mess, what do you think ?
Looks good, thanks! |
Co-authored-by: Youcef Guichi <youcef@gimlet.io>
Init Containers are now available 🚀
To mount a volume just for the init-container, use the
init-
prefix.To mount a shared volume between the init and main container, use the
shared-
prefix.Using init-containers to build and run static websites
The example bellow uses Hugo.