Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default R for Context #109

Closed
jonhoo opened this issue Feb 1, 2019 · 3 comments
Closed

Set default R for Context #109

jonhoo opened this issue Feb 1, 2019 · 3 comments

Comments

@jonhoo
Copy link
Contributor

jonhoo commented Feb 1, 2019

If we expect users to often end up with Context<EndianRcSlice<RunTimeEndian>>, should we just make that the default type? As in:

pub struct Context<R = EndianRcSlice<RunTimeEndian>> {}

That would save users of the library to explicitly type out the full type for Context in the common case!

@philipc
Copy link
Contributor

philipc commented Feb 2, 2019

Makes sense since that's what Context::new returns. You can also do a type alias in your code though.

@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 2, 2019

Oh, sure, I could totally do it in my code, but I guess the question is whether it makes sense to just include it directly in addr2line?

philipc added a commit to philipc/addr2line that referenced this issue Feb 6, 2019
@philipc
Copy link
Contributor

philipc commented Feb 7, 2019

Fixed by #111

@philipc philipc closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants