Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default R for Context and release 0.8.0 #111

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Set default R for Context and release 0.8.0 #111

merged 2 commits into from
Feb 7, 2019

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Feb 6, 2019

No description provided.

@philipc
Copy link
Contributor Author

philipc commented Feb 6, 2019

I think all the failures are due to handling of backslashes when appending paths:

system addr2line: /rustc/4b1e39b7b36d677803e40130ea29ee6d300abf6e//src/libpanic_unwind/lib.rs:92
gimli addr2line:  /rustc/4b1e39b7b36d677803e40130ea29ee6d300abf6e/src/libpanic_unwind/lib.rs:92

@philipc
Copy link
Contributor Author

philipc commented Feb 6, 2019

I'm fine with merging and releasing this. I think our behaviour is correct.

fitzgen
fitzgen approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM -- we could make the assertion a little more robust by creating a Path and canonicalizing it perhaps.

@philipc philipc merged commit eb3a8ab into gimli-rs:master Feb 7, 2019
@philipc philipc deleted the 0.8 branch February 7, 2019 02:07
@philipc philipc mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@main-- main-- Awaiting requested review from main--

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipc @fitzgen