Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid linear search for DW_FORM_ref_addr #175

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

philipc
Copy link
Contributor

@philipc philipc commented May 21, 2020

Fixes #171 (cc @mstange)

@philipc philipc requested a review from fitzgen May 21, 2020 07:16
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@philipc philipc merged commit d25f7b3 into gimli-rs:master May 21, 2020
@philipc philipc deleted the issue-171 branch May 21, 2020 22:12
@jdm
Copy link

jdm commented Jun 17, 2020

Could a new release be published with this change? I suspect this will help the performance of generating backtraces for Servo as well.

@philipc
Copy link
Contributor Author

philipc commented Jun 21, 2020

@jdm Published 0.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow find_frames on XUL.dSYM, in unit.parse_functions
3 participants