Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object to 0.8.0 #92

Closed
wants to merge 3 commits into from
Closed

Update object to 0.8.0 #92

wants to merge 3 commits into from

Conversation

est31
Copy link
Contributor

@est31 est31 commented Jun 2, 2018

Please take a close look before merging, as I don't think that we want to expose an implementation detail (arena).

@est31
Copy link
Contributor Author

est31 commented Jun 2, 2018

IDK how the arena can be put into the context struct. Is this what rental is being used for?

@est31 est31 mentioned this pull request Jun 2, 2018
14 tasks
@coveralls
Copy link

coveralls commented Jun 2, 2018

Coverage Status

Coverage increased (+0.6%) to 81.967% when pulling 66252bd on est31:master into 8f0a2f4 on gimli-rs:master.

@philipc
Copy link
Contributor

philipc commented Jun 2, 2018

This is the part that I had started work on already, rather than general no_std changes for addr2line. Yeah, rental could be used to put the arena in the context, but the way that I've been proceeding is to use an Rc or Arc version of gimli::EndianReader, which still has reasonable performance. I've just noticed that gimli::EndianReader doesn't work with Arc currently though (gimli-rs/gimli#305).

@est31
Copy link
Contributor Author

est31 commented Jun 2, 2018

Ah I see. Closing then.

@est31 est31 closed this Jun 2, 2018
@est31
Copy link
Contributor Author

est31 commented Jun 2, 2018

(in favour of your changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants