Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Send/Sync for SubRange #305

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Implement Send/Sync for SubRange #305

merged 1 commit into from
Jun 4, 2018

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Jun 2, 2018

This is needed to make EndianArcSlice useful.

It would be good if someone who knows something about Send/Sync could confirm these are actually sound.

@philipc
Implement Send/Sync for SubRange
db7f00d 
This is needed to make EndianArcSlice useful.
@philipc philipc requested a review from fitzgen June 2, 2018 01:19
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.703% when pulling db7f00d on philipc:sync into a7fe9e4 on gimli-rs:master.

This was referenced Jun 2, 2018
Closed
Merged
fitzgen
fitzgen approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@fitzgen fitzgen merged commit 77afb0a into gimli-rs:master Jun 4, 2018
@philipc philipc deleted the sync branch June 5, 2018 04:44
@est31 est31 mentioned this pull request Jun 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipc @coveralls @fitzgen