Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the
Object
trait instead ofFile
(see gimli-rs/object#53).This requires gimli-rs/gimli#305.I played a bit with using
Rc/Arc<Cow<'input, [u8]>>
instead ofEndianRcSlice
, but wasn't sure it was worth the API complexity. So I thinkContext::new
should be the simple high level interface, and consumers with more specific needs can useContext::from_sections
.Before:
After:
For reference,
Arc<Cow<[u8]>>
:The query numbers for
Arc<Cow<[u8]>>
are surprising to me, but I didn't look into it.