Add support for .eh_frame unwinding sections
#136
Conversation
|
... and apparently CI won't run until I resolve the conflicts. Will try and do that tomorrow. |
…ings may be relative to
…ns to it from cfi.rs's `tests` module
|
Ok, rebased! Not as bad as I was afraid of. |
fitzgen
changed the title
.eh_frame unwinding sections.eh_frame unwinding sections
|
I think this is ready for review, care to take a look @philipc? Thanks! |
There was a problem hiding this comment.
I couldn't review the cfi.rs changes on github, but I did look at them a bit, and looks good to me.
You might be able to avoid _UnwindSectionPrivate leaking into the docs by doing impl UnwindSection for _UnwindSectionPrivate instead of trait UnwindSection: _UnwindSectionPrivate. It'll be a bit more boilerplate that way though, so maybe not worth it.
|
|
||
| #[test] | ||
| fn test_parse_encoded_pointer_aligned() { | ||
| // FIXME! |
There was a problem hiding this comment.
Supporting pointers encoded with DW_EH_PE_aligned.
|
I'm going to land this now, but this is going to need to undergo a bit more refactoring to deal with |
Not ready to land yet -- going to need to rebase.
Take a look at the code if you want.
Mostly trying to guage whether coverage is going up or down, and see which branches I might have missed unit tests for.