Replace format/version/address_size with Encoding #364

philipc · 2019-01-20T07:52:27Z

reduces number of function parameters
makes it easier to later add support for segment sizes

coveralls · 2019-01-20T08:24:07Z

Coverage increased (+0.04%) to 87.549% when pulling 8d48220 on philipc:encoding into 9930c61 on gimli-rs:master.

- reduces number of function parameters - makes it easier to later add support for segment sizes

fitzgen

Nice!

philipc requested a review from fitzgen January 20, 2019 07:52

bjorn3 approved these changes Jan 20, 2019

View reviewed changes

Replace format/version/address_size with Encoding

8d48220

- reduces number of function parameters - makes it easier to later add support for segment sizes

philipc force-pushed the encoding branch from b38cfdb to 8d48220 Compare January 21, 2019 03:30

philipc mentioned this pull request Jan 21, 2019

Fix handling of section offsets for DWARF version 2/3 #365

Merged

fitzgen approved these changes Jan 22, 2019

View reviewed changes

philipc merged commit d8f630b into gimli-rs:master Jan 23, 2019

philipc deleted the encoding branch January 23, 2019 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace format/version/address_size with Encoding #364

Replace format/version/address_size with Encoding #364

philipc commented Jan 20, 2019

coveralls commented Jan 20, 2019 •

edited

Loading

fitzgen left a comment

Replace format/version/address_size with Encoding #364

Replace format/version/address_size with Encoding #364

Conversation

philipc commented Jan 20, 2019

coveralls commented Jan 20, 2019 • edited Loading

fitzgen left a comment

Choose a reason for hiding this comment

coveralls commented Jan 20, 2019 •

edited

Loading