Fix handling of section offsets for DWARF version 2/3 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Jan 22, 2019
This is nearly always what is needed.
For writing, we must use DW_FORM_data4/8 instead of DW_FORM_sec_offset for version 2/3. For reading, we weren't handling relocations for DW_FORM_data4/8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #364.
For writing, we must use
DW_FORM_data4/8instead ofDW_FORM_sec_offsetfor version 2/3.For reading, we weren't handling relocations for
DW_FORM_data4/8.There's also a commit to always do endian conversions on
DW_FORM_data2/4/8. I think this is usually what we want, and it makes the fixes in this PR simpler. See also https://github.com/bjorn3/rustc_codegen_cranelift/pull/291#discussion_r249264661.