Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.51.0 #651

Closed
wants to merge 2 commits into from
Closed

Bump MSRV to 1.51.0 #651

wants to merge 2 commits into from

Conversation

tamird
Copy link
Contributor

@tamird tamird commented May 3, 2023

See individual commit messages.

cc @philipc since MSRV was effectively bumped in 059c553.

tamird added 2 commits May 4, 2023 10:08
This was effectively done in 059c553
which bumped the dependency on the object crate to 0.30.0; the object
crate introduced the use of `resolver = "2"` in its Cargo.toml in
gimli-rs/object@1eb82ff
which was included in its 0.30.0 release.
@tamird tamird changed the title Pin miniz_oxide in MSRV build Bump MSRV to 1.51.0 May 4, 2023
@philipc
Copy link
Collaborator

philipc commented May 4, 2023

object is a dev dependency only, so it doesn't affect MSRV. It does make it hard to test the MSRV though.

@tamird
Copy link
Contributor Author

tamird commented May 4, 2023

Sent #652 as an alternative solution.

@philipc
Copy link
Collaborator

philipc commented May 5, 2023

I've merged #653 instead. While we don't really need to support something as old as 1.42.0, I don't want to change it until we have other breaking changes.

@philipc philipc closed this May 5, 2023
@tamird tamird deleted the msrv branch May 5, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants