Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read: add impl fallible-iterator for OperationIter #649

Merged
merged 1 commit into from
May 5, 2023
Merged

read: add impl fallible-iterator for OperationIter #649

merged 1 commit into from
May 5, 2023

Conversation

tamird
Copy link
Contributor

@tamird tamird commented May 3, 2023

No description provided.

@tamird
Copy link
Contributor Author

tamird commented May 3, 2023

Looks like CI is failing because oxide_miniz is using slice::fill and u32::MAX which were stabilized in 1.50.0 and 1.43.0 respectively.

It also seems to be using a loop in a constant context which was stabilized in 1.46.0 citation.

@tamird
Copy link
Contributor Author

tamird commented May 3, 2023

Hopefully #651 fixes the build.

@philipc philipc merged commit 0c71b5a into gimli-rs:master May 5, 2023
16 of 19 checks passed
@tamird tamird deleted the operation-iter-fallible-iterator branch May 5, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamird @philipc