Bugs/isatty hot path #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result from isatty is immutable during the run of the program and
is triggering a heavy system call that significantly slow down answering
request.
$ benchstat before.txt after.txt
goos: darwin
goarch: amd64
pkg: github.com/gin-contrib/logger
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
│ before.txt │ after.txt │
│ sec/op │ sec/op vs base │
Logger 2.924µ ± 2% 1.617µ ± 12% -44.70% (p=0.000 n=10)
Logger-2 1649.0n ± 2% 766.1n ± 1% -53.54% (p=0.000 n=10)
Logger-4 1009.5n ± 11% 496.6n ± 12% -50.80% (p=0.000 n=10)
Logger-8 853.4n ± 3% 396.4n ± 12% -53.56% (p=0.000 n=10)
geomean 1.428µ 702.7n -50.78%
appleboy
approved these changes
Jul 9, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 97.52% 97.50% -0.03%
==========================================
Files 2 2
Lines 121 120 -1
==========================================
- Hits 118 117 -1
Misses 2 2
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing isatty call from the hot path significantly improve performance when using gin and zerolog via gin-contrig/logger.