Fix handling of WriteString in gzip middleware #59
Conversation
|
Nice! Thank you. |
|
Any updates here? This is a very minor fix and being unable to use |
|
Is this repo dead? |
|
Yeah. I would like to see this merged. Experiencing the same problem here. |
|
This was also breaking gzip for me. Adding in the missing WriteString method fixed the issue. |
This is a fix in a fork. I'm making a copy so I can build my project off of my own repo until the code is merged into the main project. The original issue was reported and a fixed provided here: gin-gonic#59
|
Is there any update on this? I cannot compress my output using gzip and some of my JSON will be large. I really don't want to proxy behind nginx if I don't have to. |
| @@ -42,6 +42,10 @@ type gzipWriter struct { | |||
| writer *gzip.Writer | |||
| } | |||
|
|
|||
| func (g *gzipWriter) WriteString(s string) (n int, err error) { | |||
There was a problem hiding this comment.
Please drop the variable names from the return values
|
Somebody can also create a new pr if the author doesn't update this :) |
This fixes code-review requests mentioned in gin-gonic#59
|
So let's close this in favor of #118 |
When using the gzip middleware, calls to WriteString were falling through to
using the embedded gin.ResponseWriter's WriteString. This would sidestep
the gzip encoder and inject uncompressed data into the output.
This change makes the gzip middleware handle the call itself.
Running the 'TestGzip' test in the existing test suite demonstrates the issue.