Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hello.go #1598

Closed
wants to merge 1 commit into from
Closed

Update hello.go #1598

wants to merge 1 commit into from

Conversation

dickanirwansyah
Copy link

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integrations systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #1598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1598   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          39       39           
  Lines        1928     1928           
=======================================
  Hits         1914     1914           
  Misses         10       10           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa092f...e5eb3cf. Read the comment docs.

@@ -21,4 +21,5 @@ func init() {

// Handle all requests using net/http
http.Handle("/", r)
r.Run(":3000")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Handle, so not need Run.

@thinkerou thinkerou closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants