Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tree.go #2659

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Update tree.go #2659

merged 1 commit into from
Jun 22, 2021

Conversation

youzeliang
Copy link
Contributor

delete more "()"

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@youzeliang
Update tree.go
a0842be 
delete more "()"
@youzeliang
Copy link
Contributor Author

delete more "()"

@thinkerou thinkerou self-requested a review March 27, 2021 01:12
@thinkerou thinkerou modified the milestone: 1.7 Mar 27, 2021
thinkerou
thinkerou approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou added this to the 1.7 milestone Mar 28, 2021
@thinkerou thinkerou modified the milestones: 1.7, v1.8 Mar 31, 2021
daheige
daheige approved these changes May 1, 2021
View reviewed changes
Copy link
Contributor

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #2659 (a0842be) into master (1bdf86b) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2659      +/-   ##
==========================================
+ Coverage   98.64%   98.82%   +0.17%     
==========================================
  Files          41       41              
  Lines        1989     2458     +469     
==========================================
+ Hits         1962     2429     +467     
- Misses         15       17       +2     
  Partials       12       12
Impacted Files Coverage Δ
tree.go 100.00% <100.00%> (ø)
routergroup.go 100.00% <0.00%> (ø)
render/msgpack.go 100.00% <0.00%> (ø)
binding/binding.go 100.00% <0.00%> (ø)
binding/msgpack.go 100.00% <0.00%> (ø)
context.go 97.62% <0.00%> (+0.11%) ⬆️
gin.go 99.40% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdf86b...a0842be. Read the comment docs.

@thinkerou thinkerou merged commit 61a0cda into gin-gonic:master Jun 22, 2021
thinkerou added a commit that referenced this pull request Jun 24, 2021
@wei840222 @youzeliang
@imaskm @laojianzi @thinkerou @appleboy @ItalyPaleAle
gin.Context with fallback value from gin.Context.Request.Context() (#…
7834a03 
…2751)

* Update tree.go (#2659)

delete more "()"

* updated comments for Get function for params (#2756)

* ci: add github action workflows (#2596)

* ci: add github action workflows

* test: fixed the TestUnixSocket test on windows (#20)

* ci: add github action workflows (#18)

* Remove .travis.yml

* ci: replace GITTER_ROOM_ID and upload coverage every time you go test

* ci: update coverage using codecov/codecov-action@v1

* Merge branch 'master' into github-actions

* repo: replace travis ci to github actions

* ci: add go version 1.16

* fix: go install requires a specific version

* chore(ci): remove go 1.12 support

* chore(ci): remove os windows-latest

Co-authored-by: thinkerou <thinkerou@gmail.com>
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* Setting trusted platform using an enum-like (#2739)

* gin.Context with fallback value from c.Request.Context()

* add test case

Co-authored-by: youzeliang <youzel@126.com>
Co-authored-by: Ashwani <ashwanisharma686@gmail.com>
Co-authored-by: Jeff <laojianzi1994@gmail.com>
Co-authored-by: thinkerou <thinkerou@gmail.com>
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
@youzeliang @Bisstocuz
Update tree.go (gin-gonic#2659)
79401cb 
delete more "()"

(cherry picked from commit 61a0cda)
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
@youzeliang @Bisstocuz
Update tree.go (gin-gonic#2659)
1e885d4 
delete more "()"

(cherry picked from commit 61a0cda)
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
@youzeliang @Bisstocuz
Update tree.go (gin-gonic#2659)
00523fb 
delete more "()"

(cherry picked from commit 61a0cda)
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
@youzeliang @Bisstocuz
Update tree.go (gin-gonic#2659)
da606c6 
delete more "()"

(cherry picked from commit 61a0cda)
thinkerou pushed a commit that referenced this pull request Nov 23, 2021
@youzeliang @thinkerou
Update tree.go (#2659)
aebfa3e 
delete more "()"
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 23, 2021
@youzeliang @Bisstocuz
Update tree.go (gin-gonic#2659)
2296c03 
delete more "()"

(cherry picked from commit 61a0cda)
thinkerou pushed a commit that referenced this pull request Nov 24, 2021
@youzeliang @thinkerou
Update tree.go (#2659)
c08ec1a 
delete more "()"
thinkerou pushed a commit that referenced this pull request Nov 24, 2021
@youzeliang @thinkerou
Update tree.go (#2659)
04d8641 
delete more "()"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou thinkerou approved these changes

@daheige daheige daheige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@youzeliang @appleboy @thinkerou @daheige