load external resources with the same protocol as the page itself. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
As far as i know, thats the canonical way to tell the browser to use the same protocol as the document it is in. But you bring up an interesting question.
No i am not sure how widely supported it is. I just assumed...
…On July 17, 2017 10:26:06 PM GMT+02:00, Barry Carter ***@***.***> wrote:
Thanks!
I see you removed the http entirely. Is that fully supported?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#5 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
actually, it seems that the consensus is to switch from protocol relative URLs to https-always. So maybe you want to amend the pull request before merging, or deny it and make the change yourself :) Reference: https://stackoverflow.com/questions/28446314/why-use-protocol-relative-urls-at-all |
|
interesting. I'm learning a lot here. From reading a couple more pages, you're right I should change to https. Appreciate it either way, thanks! |
Changed URLs to the full https see discussion and https://stackoverflow.com/questions/28446314/why-use-protocol-relative-urls-at-all Appreciate the submission!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the javascript on the website is not working because jquery is loaded over http:// while the page itself is loaded over https://. That doesn't work on modern browsers anymore.