Merge Fix EnableLogging superclass

Fix EnableLogging superclass Related PR: #841
ginkgo-project · Aug 5, 2021 · 6c5ff35 · 6c5ff35
2 parents 5c48189 + e8001b5
commit 6c5ff35
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/include/ginkgo/core/log/logger.hpp b/include/ginkgo/core/log/logger.hpp
@@ -584,7 +584,7 @@ class Loggable {
  *                          class.
  */
 template <typename ConcreteLoggable, typename PolymorphicBase = Loggable>
-class EnableLogging : public Loggable {
+class EnableLogging : public PolymorphicBase {
 public:
     void add_logger(std::shared_ptr<const Logger> logger) override
     {
@@ -593,10 +593,9 @@ class EnableLogging : public Loggable {
 
     void remove_logger(const Logger *logger) override
     {
-        auto idx = find_if(begin(loggers_), end(loggers_),
-                           [&logger](std::shared_ptr<const Logger> l) {
-                               return lend(l) == logger;
-                           });
+        auto idx =
+            find_if(begin(loggers_), end(loggers_),
+                    [&logger](const auto &l) { return lend(l) == logger; });
         if (idx != end(loggers_)) {
             loggers_.erase(idx);
         } else {