hip device guard rule-5

ginkgo-project · Oct 23, 2019 · c653acb · c653acb
1 parent bee3b42
commit c653acb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/benchmark/spmv/hip_linops.hip.hpp → benchmark/utils/hip_linops.hip.hpp b/benchmark/spmv/hip_linops.hip.hpp → benchmark/utils/hip_linops.hip.hpp
diff --git a/hip/base/device_guard.hip.hpp b/hip/base/device_guard.hip.hpp
@@ -40,6 +40,14 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 namespace gko {
 
 
+/**
+ * This class defines a device guard for the hip functions and the hip module.
+ * The guard is used to make sure that the device code is run on the correct
+ * hip device, when run with multiple devices. The class records the current
+ * device id and uses `hipSetDevice` to set the device id to the one being
+ * passed in. After the scope has been exited, the destructor sets the device_id
+ * back to the one before entering the scope.
+ */
 class hip_device_guard {
 public:
     hip_device_guard(int device_id)
@@ -48,6 +56,14 @@ class hip_device_guard {
         GKO_ASSERT_NO_HIP_ERRORS(hipSetDevice(device_id));
     }
 
+    hip_device_guard(hip_device_guard &other) = delete;
+
+    hip_device_guard &operator=(const hip_device_guard &other) = delete;
+
+    hip_device_guard(hip_device_guard &&other) = delete;
+
+    hip_device_guard const &operator=(hip_device_guard &&other) = delete;
+
     ~hip_device_guard() noexcept(false)
     {
         /* Ignore the error during stack unwinding for this call */