Apply command #47
Merged
Apply command #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris7
force-pushed
the
cross-branch-operations
branch
2 times, most recently
from
ca972d8
to
2116ba6
Compare
dkhofer
reviewed
Sep 23, 2024
| let mut dfs = DfsPostOrder::new(&graph, creation_id); | ||
|
|
||
| // Traverse all transitive predecessors | ||
| while let Some(ancestor) = dfs.next(&graph) { |
There was a problem hiding this comment.
I'm confused, this is adding all operations to the return vec, and then below, we're adding just those operations for the input branch, which I assume would all be redundant
There was a problem hiding this comment.
Never mind, just saw the creation_id thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for applying a changeset to a given branch.