Improve and fix buildsystem #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version required by PortPlacement now matches the version required by Slicer
Since Eigen3 now provides a config file and is available through the extension index, this commit removes the local FindEigen3 module and explicitly makes use of the CONFIG mode (this avoid attempt to use FindEigen3.cmake provided by VTK).
This commit partially reverts 869bfd5 (ENH: Remove nlopt source tree from PortPlacement code base) and download NLopt to fix allow the extension to build on Linux, macOS and Windows.
This commit allows other extensions to reuse PortPlacement objects.
This commit fixes the following error: ``` from /tmp/PortPlacement/AutoPortPlacement/qSlicerAutoPortPlacementModule.cxx:19: /tmp/PortPlacement/AutoPortPlacement/qSlicerAutoPortPlacementModule.cxx:29:1: error: static assertion failed: Old plugin system used Q_EXPORT_PLUGIN2(qSlicerAutoPortPlacementModule, qSlicerAutoPortPlacementModule); ^ ```
This commit fixes the following runtime error: ``` 2: File "/tmp/PortPlacement/PortPlacement/PortPlacement.py", line 238, in onRemovePortButton 2: index = self.portsTable.selectionModel().currentIndex() 2: TypeError: 'QModelIndex' object is not callable ``` ``` 2: Traceback (most recent call last): 2: File "/tmp/PortPlacement/PortPlacement/PortPlacement.py", line 735, in test_PortPlacement1 2: logic.toolList[i].modelNode.TransformPointFromWorld(targetWorld, targetLocal) 2: TypeError: TransformPointFromWorld argument 1: expected a sequence of 3 values, got 4 values ```
This commit fixes warnings like the following:
```
/tmp/PortPlacement/AutoPortPlacement/Logic/tests/min-distance-test.cxx:5:14: warning: unused parameter ‘argc’ [-Wunused-parameter]
int main(int argc, char* argv[])
^
/tmp/PortPlacement/AutoPortPlacement/Logic/tests/min-distance-test.cxx:5:31: warning: unused parameter ‘argv’ [-Wunused-parameter]
int main(int argc, char* argv[])
^
```
This commit fixes the following warning:
```
tmp/PortPlacement/AutoPortPlacement/Logic/davinci-kinematics/davinci.cxx:726:10: warning: ‘double {anonymous}::fromPoseToExtraClearance(const DavinciKinematics&, const Matrix4d&, const Matrix4d&, const Matrix4d&)’ defined but not used [-Wunused-function]
double fromPoseToExtraClearance(const DavinciKinematics& kin,
^
```
|
Cc: @andinet |
|
All tests pass. 🎆 Only issue is that I wonder if it would make sense to add the timeout as a parameter of |
|
Thanks @giogadi 👍 Hope things are going well out West |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.