Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxdim=0 #39

Closed
mglisse opened this issue Nov 1, 2021 · 2 comments · Fixed by #40
Closed

maxdim=0 #39

mglisse opened this issue Nov 1, 2021 · 2 comments · Fixed by #40
Labels
bug Something isn't working
Projects
v0.2.0

Comments

@mglisse
Copy link

mglisse commented Nov 1, 2021

Hello,
I tried to run gph.ripser_parallel(np.array([[1.,2],[3,4],[5,0]]), maxdim=0) but it segfaults (while it works with maxdim=1).
MonkeyBreaker pushed a commit that referenced this issue Nov 2, 2021
[TEST] Add regression test for issue #39
af1d9cf 
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
@MonkeyBreaker MonkeyBreaker mentioned this issue Nov 2, 2021
Merged
@MonkeyBreaker MonkeyBreaker linked a pull request Nov 2, 2021 that will close this issue
Fix issue when computing PH with maxdim == 0 #40
Merged
@MonkeyBreaker
Copy link
Collaborator

Hello,

Thank you for reporting the issue. After debugging what was going on, I found out a fix.
Currently a PR (#40) is in progress for patching this issue.

Sorry that you encountered a bug and thank you for reporting it with an example.

Best,
Julián

@ulupo ulupo added the bug Something isn't working label Nov 2, 2021
@ulupo ulupo added this to To do in v0.2.0 via automation Nov 2, 2021
v0.2.0 automation moved this from To do to Done Nov 2, 2021
MonkeyBreaker pushed a commit that referenced this issue Nov 2, 2021
Fix issue when computing PH with maxdim == 0 (#40)
3bdc8fa 
* [TEST] Add regression test for issue #39

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>

* [CPP] Fix issue when maxdim == 0

get_zero_apparent_cofacet was assuming that we were calling the function
with maxdim > 0 inside of method compute_dim_0

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>

* [TEST] Update test test_ph_maxdim_0

Now the test also computes with maxdim == 1 and compares barcodes
in dimension 0 for both runs

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>

* [TEST] Use as suggested by @ulupo assert_array_equal

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>

* [TEST] Update with @ulupo suggestions

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
@MonkeyBreaker
Copy link
Collaborator

MonkeyBreaker commented Nov 2, 2021 •
edited by ulupo

The fix is now merged but currently not available in PyPI.
We will soon release version 0.2.0, but on the meantime if you want to work with giotto-ph with maxdim=0 fix, you can follow the developer installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
v0.2.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue when computing PH with maxdim == 0 giotto-ai/giotto-ph
3 participants
@mglisse @MonkeyBreaker @ulupo