Fix issue when computing PH with maxdim == 0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2021 08:11
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
get_zero_apparent_cofacet was assuming that we were calling the function with maxdim > 0 inside of method compute_dim_0 Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Closed
Closed
ulupo
requested changes
Nov 2, 2021
Now the test also computes with maxdim == 1 and compares barcodes in dimension 0 for both runs Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
ulupo
requested changes
Nov 2, 2021
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
ulupo
requested changes
Nov 2, 2021
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
|
Thank you for all the review Umbe, if all test passes, I will merge the PR. |
|
@MonkeyBreaker sure! I prefer squash and merge for a cleaner history (not sure if this is what you prefer too) |
I will then squash and merge, I prefer we stay consistent 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #39 when computing persistent homology with the maximal dimension set to 0.
The issue was that in function
compute_dim_0, we also prepare the columns to reduce for dimensions 1. But, whenmaxdim=0, we don't care about preparing those columns. Even worse was thatget_zero_apparent_cofacet(e, 1)was assuming that we were always computing formaxdim>0.This is now fixed by preparing the columns for dimension only if
maxdim > 0.