Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add Python version 3.10, make sure pip and setuptools are upgraded during the CI #47

Merged
merged 8 commits into from
Nov 9, 2021

Conversation

ulupo
Copy link
Collaborator

@ulupo ulupo commented Nov 8, 2021

Partially addresses #45, and ensures pip and setuptools are updated. This is important as e.g. the correct installation of our dependencies depends on having these packages up-to-date (we similarly upgrade in giotto-tda and pyflagser).

@ulupo
Copy link
Collaborator Author

ulupo commented Nov 8, 2021

@MonkeyBreaker if this works, we could maybe merge it and then make another PR from a branch here (not in one of our forks) to verify whether the wheels can be built already or we really need to upgrade the manylinux version in view of SciPy's news: https://github.com/scipy/scipy/releases/tag/v1.7.2

@ulupo ulupo changed the title [CI] Upgrade ccache, add Python version 3.10, make sure pip and setup… [CI] Add Python version 3.10, make sure pip and setuptools are upgraded during the CI Nov 8, 2021
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ulupo
Copy link
Collaborator Author

ulupo commented Nov 8, 2021

@MonkeyBreaker sorry, I guess we need to mirror these changes into a new branch in giotto-ai to test whether the wheel building step would work with Python 3.10!

@ulupo
Copy link
Collaborator Author

ulupo commented Nov 8, 2021

@MonkeyBreaker sorry, I guess we need to mirror these changes into a new branch in giotto-ai to test whether the wheel building step would work with Python 3.10!

Or we can merge this as is (since the CI passes) and worry about whether we can build wheels for Python 3.10 after the merge? After all, it's OK for us to test for Python 3.10 already now even if we don't yet produce wheels for it.

@ulupo ulupo marked this pull request as ready for review November 8, 2021 18:48
@ulupo ulupo added this to In progress in v0.2.0 via automation Nov 8, 2021
@MonkeyBreaker
Copy link
Collaborator

I just started the building of the wheels on your branch https://github.com/ulupo/giotto-ph/actions/runs/1436504308
When touching the CI, I think it would be better to create a branch directly into origin, that way we can run the Action directly from here.

If the builds build fine, then yes, we can merge, otherwise I will debug what is going on :)

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
@MonkeyBreaker
Copy link
Collaborator

MonkeyBreaker commented Nov 9, 2021

The wheels for Python 3.6 to Python 3.10 can be now generated 🎉 ! (see)
@ulupo do you want to address the comment about the dependencies now or should we do it in a later PR ?

Copy link
Collaborator Author

@ulupo ulupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy with this comment I am happy to merge this!

.github/workflows/wheels.yml Show resolved Hide resolved
Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ulupo
Copy link
Collaborator Author

ulupo commented Nov 9, 2021

Are you sure that pip install -e . does pull latest version of the packages ?

@MonkeyBreaker see https://pip.pypa.io/en/stable/cli/pip_install/ (Satisfying Requirements). So yes except for pre-releases sometimes.

@MonkeyBreaker
Copy link
Collaborator

@MonkeyBreaker see https://pip.pypa.io/en/stable/cli/pip_install/ (Satisfying Requirements). So yes except for pre-releases sometimes.

Alright, perfect, we could remove it now then, what do you think ?

@ulupo
Copy link
Collaborator Author

ulupo commented Nov 9, 2021

Alright, perfect, we could remove it now then, what do you think ?

I think yes! Go for it!

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
@MonkeyBreaker
Copy link
Collaborator

Done, when the pipelines ends, then let's Merge !

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@MonkeyBreaker
Copy link
Collaborator

LGTM !

@ulupo ulupo merged commit d6c372b into giotto-ai:main Nov 9, 2021
v0.2.0 automation moved this from In progress to Done Nov 9, 2021
@ulupo ulupo deleted the CI/fix_pip_manylinux_scipy branch November 9, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants