-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add Python version 3.10, make sure pip and setuptools are upgraded during the CI #47
Conversation
@MonkeyBreaker if this works, we could maybe merge it and then make another PR from a branch here (not in one of our forks) to verify whether the wheels can be built already or we really need to upgrade the manylinux version in view of SciPy's news: https://github.com/scipy/scipy/releases/tag/v1.7.2 |
@MonkeyBreaker sorry, I guess we need to mirror these changes into a new branch in giotto-ai to test whether the wheel building step would work with Python 3.10! |
Or we can merge this as is (since the CI passes) and worry about whether we can build wheels for Python 3.10 after the merge? After all, it's OK for us to test for Python 3.10 already now even if we don't yet produce wheels for it. |
I just started the building of the wheels on your branch https://github.com/ulupo/giotto-ph/actions/runs/1436504308 If the builds build fine, then yes, we can merge, otherwise I will debug what is going on :) |
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're happy with this comment I am happy to merge this!
Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
@MonkeyBreaker see https://pip.pypa.io/en/stable/cli/pip_install/ (Satisfying Requirements). So yes except for pre-releases sometimes. |
Alright, perfect, we could remove it now then, what do you think ? |
I think yes! Go for it! |
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Done, when the pipelines ends, then let's Merge ! |
LGTM ! |
Partially addresses #45, and ensures
pip
andsetuptools
are updated. This is important as e.g. the correct installation of our dependencies depends on having these packages up-to-date (we similarly upgrade ingiotto-tda
andpyflagser
).