-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small codebase updates #50
Conversation
See https://www.gnu.org/software/gcc/gcc-11/porting_to.html\#header-dep-changes Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
The new names should also fix the assert in the operator method Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
…of 64 Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
For removing some code duplication, I need to add a constructor to boundary_enumerator Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
@ulupo if you think of anything else that should be added to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort, thank you very much! A quick comment before a full review: I was under the impression that Ripser/ripser implemented its own is_prime function in C++. What is the reason for not incorporating it here?
Well, the function |
As suggested by @ulupo this method is not much faster Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
Store max coefficient value in a variable and use then the variable Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
…nt dim Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
This could be easely achieved in Python Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
This PR addresses multiples small issues here and there in the code base that where on my to-do list:
binomial_coeff_table
as requested by @ulupofloat
32-bit precision used instead of Python default onefloat
64-bit precision. The return value is therefore composed of Numpy arrays.algorithm
header.num_edges
return value who is unused and if needed, can be easily computed in Python.