Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small codebase updates #50

Merged
merged 23 commits into from
Dec 6, 2021
Merged

Small codebase updates #50

merged 23 commits into from
Dec 6, 2021

Commits on Nov 10, 2021

  1. [CPP] Update header dependency change in GCC 

    See https://www.gnu.org/software/gcc/gcc-11/porting_to.html\#header-dep-changes

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    60de338 View commit details
    Browse the repository at this point in the history

  2. [CPP] Update binomial_coefficient_table names as suggested by @ulupo 

    The new names should also fix the assert in the operator method

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    23b24cc View commit details
    Browse the repository at this point in the history

  3. [CPP] Fix order of attributes for packed argument on GCC and LLVM 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    cd89a17 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. [BIND] Update type returned for barcodes to be of np.float32 instead … 

    …of 64

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    0ad94aa View commit details
    Browse the repository at this point in the history

  2. [PY] Add comment to new behavior of value returned from bindings 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    3253b0f View commit details
    Browse the repository at this point in the history

  3. [CPP] Add templates to apparent section 

    For removing some code duplication, I need to add a constructor to boundary_enumerator

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    c461325 View commit details
    Browse the repository at this point in the history

  4. [TEST] Add test for unsupported coefficient values 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    d9a79f9 View commit details
    Browse the repository at this point in the history

  5. [CPP] Retrieve maximal coefficient value supported from CPP 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    28cd650 View commit details
    Browse the repository at this point in the history

  6. [PY] Add coefficient verification 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    e6b3a28 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Fix test_gens_with_collapser docstring

    @ulupo
    ulupo authored Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6f9684b View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Fix typo in gph/src/ripser.h

    @ulupo
    ulupo authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0a0067a View commit details
    Browse the repository at this point in the history

  2. [PY] Update _supported_coeff_field to _is_prime_and_larger_than_2 

    As suggested by @ulupo this method is not much faster

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    1dfb958 View commit details
    Browse the repository at this point in the history

  3. [SRC] Add comment requested by @ulupo for binomial_coeff_table 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    5e02ba5 View commit details
    Browse the repository at this point in the history

  4. Add source of algorithm 

    Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
    @ulupo
    Julián and ulupo authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    bf3bc99 View commit details
    Browse the repository at this point in the history

  5. [PY] Update as suggested by @ulupo 

    Store max coefficient value in a variable and use then the variable

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    1745d88 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Update comment related to barcodes from bindings 

    Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
    @ulupo
    Julián and ulupo authored Nov 25, 2021
    Configuration menu
    Copy the full SHA
    74ef770 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. [CPP] Try to improve variable names in compute_pairs 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    b1d074f View commit details
    Browse the repository at this point in the history

  2. [CPP] Pre-allocate maximal number of entries in the hashmap for curre… 

    …nt dim

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    a64a3a4 View commit details
    Browse the repository at this point in the history

  3. [CPP] Remove ratio parameter, it was unused 

    This could be easely achieved in Python

Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    051c57f View commit details
    Browse the repository at this point in the history

  4. [CPP] Remove num_edges unused variable 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    089b4c0 View commit details
    Browse the repository at this point in the history

  5. [CPP] Fix format issues 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    01e06eb View commit details
    Browse the repository at this point in the history

  6. Imrpove _is_prime_and_larger_than_2 as suggested by @ulupo 

    Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
    @ulupo
    Julián and ulupo authored Dec 4, 2021
    Configuration menu
    Copy the full SHA
    a67c461 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. [CPP] Update more variable names according to @ulupo feedback 

    Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
    julian committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    2924439 View commit details
    Browse the repository at this point in the history