Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in git history #1

Closed
gtauzin opened this issue Oct 15, 2019 · 1 comment
Closed

Changes in git history #1

gtauzin opened this issue Oct 15, 2019 · 1 comment

Comments

@gtauzin
Copy link
Collaborator

gtauzin commented Oct 15, 2019

Please be aware that the final moving from gitlab to github has led us to modify git history.

@rth, could you please refork?

@rth
Copy link
Collaborator

rth commented Oct 15, 2019

Sure, will do. Thanks @gtauzin !

@gtauzin gtauzin closed this as completed Oct 18, 2019
lewtun pushed a commit that referenced this issue Dec 20, 2019
Filter + hypothesis tests + Mapper skeleton class
ulupo added a commit that referenced this issue Jan 16, 2020
* Refactoring of create_network_2d to fix (#121), (#125), (#127), (#128)

- A suggestion of a template for fixing all the above issues in the static and 2d case.
- Some necessary changes also performed in `utils.visualization.py`
- Mapper Quickstart notebook updated to show new behaviour with a pandas dataframe example

NOTE IMPORTANT: this has broken create_interactive_network, which will need to be refactored separately if these changes are accepted. Also, no change has been made to create_network_3d, pending approval for 2d.

* Rename node_color argument to node_color_statistic

* Refactor name of is_node_colors_ndadday to is_node_colors_ndarray

* Extend functionality from 2D visualisation to 3D

- Does not include the hoverlabel

* Set hoverlabel background color for 3D visualisation

* Fix linting in visualisation

* Extend interactive visualisation to include new API

* Fix linting

* Add "Color by" annotation to 3D visualisation

* Move viridis colorscale to top of dropdown list

Since the default colorscale is viridis, it makes sense to show the user this value at the top of the dropdown

* Refactor 2D and 3D networks into single function

* Merge plot_options from 2D and 3D networks and remove colorscale dropdown

* Merge plot and layout options from 2D and 3D plots

* Change sliders for filter params to bounded boxes

* Fix layout options for 2D and 3D plots

* Add docstring for dim argument

* Refactor case handling for 2D vs 3D plotting into single if statement

* Refactor 3D if statement to single clause

* Remove 2D and 3D plotting functions

* Remove canonical node ID from hover text

* Update init for static function

* Add 3D functionality to interactive plot

* Clone pipeline in static plotting

* Update quickstart notebook for new API changes

* Modularise case checking to helper functions

* Update quickstart notebook for new API

* Fix bug with layout dim refactoring

* Remove unused helper function for color scales

* Sort imports in visualisation.py

* Add TODO comment on JIT computation for color by columns

* Change name of hoverlabel text variables

* Refactor name of _is_array_or_dataframe() utility function

* Fix docstring to reflect change from node_colors to node_color_statistic

* Fix name of attribute names in docstrings and use US english for color

* Add clone_pipeline bool and remove get_figure() utility function

* Migrate examples docstring to issue #152

* Refactor setting of cover parameters to be generic for ints and floats

* Add string-based widget for cover

* Change color_by_column default value to False

* Tidy up color_variable explanation in docstrings

* Update quickstart notebook to match API changes

* Remove unused get_figure() helper function

* Remove submit button by setting continuous_update False

* Clean up commented out code from removal of submit button

* Add comment about cloning pipeline

* Refactor update_figure() to accept node and edge traces

Saves memory by avoiding need to create a new plotly Figure object with each update

* Clean up function signatures and variable names for node and edge traces

* Tweak whitespace in comment

* Refactor helper function to reflect changes to return

* Update quickstart notebook to reflect changes

* Fix docstring to remove attr

* Fix docstring for color by columns dropdown default value

Co-authored-by: Umberto Lupo <46537483+ulupo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants