Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeatKernel sigma param should accept int type #89

Closed
nphilou opened this issue Nov 19, 2019 · 0 comments
Closed

HeatKernel sigma param should accept int type #89

nphilou opened this issue Nov 19, 2019 · 0 comments

Comments

@nphilou
Copy link
Contributor

nphilou commented Nov 19, 2019

Description

TypeError thrown with integer sigma value for HeatKernel

Steps/Code to Reproduce

hk = HeatKernel(1, n_values=100, n_jobs=-1)
hk.fit(x_whatever)

Expected Results

No TypeError

Actual Results

TypeError: Parameter sigma is of type <class 'int'> while it should be of type <class 'float'>

Versions

Darwin-18.7.0-x86_64-i386-64bit
Python 3.7.3 (default, Mar 27 2019, 16:54:48)
[Clang 4.0.1 (tags/RELEASE_401/final)]
NumPy 1.17.3
SciPy 1.3.1
joblib 0.14.0
Scikit-Learn 0.21.3
giotto-Learn 0.1.2
ulupo pushed a commit to ulupo/giotto-tda that referenced this issue Nov 20, 2019
Fix (giotto-ai#89) by using numbers.Number
4400f96
@ulupo ulupo mentioned this issue Nov 20, 2019
Merged
ulupo added a commit that referenced this issue Nov 21, 2019
@ulupo
Merge pull request #93 from ulupo/fix_validation
7e693b7 
Fix (#89) by using numbers.Number
@ulupo ulupo closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nphilou @ulupo