Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows PyPI distribution woes due to direct reference specifications #225

Merged
merged 3 commits into from Jan 24, 2020

Conversation

ulupo
Copy link
Collaborator

@ulupo ulupo commented Jan 24, 2020

What does this implement/fix? Explain your changes.

  • Abandon direct reference specifications approach to installing the python-igraph dependency on Windows
  • Fix step supposed to replace giotto-tda with giotto-tda-nightly in azure-pipelines.yml
  • Credit Martino Milani in RELEASE.rst

ulupo and others added 3 commits January 24, 2020 09:55
…thon-igraph dependency on Windows (#223)

* Fix small docs issues with mapper.pipeline

* Change setup.py & azure-pipelines to avoid python-igraph + PyPI upload issues

- python-igraph added to requirements.txt
- Dispense of different treatment of python-igraph and pycairo when the platform is Windows
- Add python script in .azure-ci to extract Windows wheel URLs for pycairo and python-igraph, to be used in azure-pipelines
- Add explicit installation steps for pycairo and python-igraph to azure-pipelines
- Linting in azure-pipelines

* Fix step supposed to replace giotto-tda with giotto-tda-nightly

* Add instructions for manual pycairo and python-igraph install on Windows
Credit Martino Milani in RELEASE.rst
@ulupo ulupo requested a review from wreise January 24, 2020 11:02
@ulupo ulupo changed the title Fix Windows PyPI distribution woes due to direct reference specifications from 5025215 Fix Windows PyPI distribution woes due to direct reference specifications from 5025215719639db85577034a6f3aba19fe973878 Jan 24, 2020
@ulupo ulupo changed the title Fix Windows PyPI distribution woes due to direct reference specifications from 5025215719639db85577034a6f3aba19fe973878 Fix Windows PyPI distribution woes due to direct reference specifications Jan 24, 2020
@ulupo ulupo merged commit cd78ec8 into 0.1.X Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants