Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ParallelClustering picklable, fixing memory caching in Mapper pipelines #597

Merged
merged 3 commits into from Jul 9, 2021

Conversation

ulupo
Copy link
Collaborator

@ulupo ulupo commented Jul 9, 2021

Reference issues/PRs
Fixes #596

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description
Fixed by avoiding using lambdas and added a regression test.

Screenshots (if appropriate)

Any other comments?

Checklist

  • I have read the guidelines for contributing.
  • My code follows the code style of this project. I used flake8 to check my Python changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. I used pytest to check this on Python tests.

@ulupo ulupo merged commit b760d6a into giotto-ai:master Jul 9, 2021
@ulupo ulupo deleted the fix_parallelclustering_memory branch July 9, 2021 04:57
ulupo added a commit that referenced this pull request Jul 9, 2021
* Make ParallelClustering picklable, fixing memory caching in Mapper pipelines (#597)

* Prepare v0.5.1 (#598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memory caching globally broken in Mapper pipelines because ParallelClustering cannot be pickled
1 participant