Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pybind11 #689

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Updating pybind11 #689

merged 1 commit into from
Mar 5, 2024

Conversation

rballeba
Copy link
Contributor

@rballeba rballeba commented Mar 5, 2024

Reference issues/PRs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Updating pybind submodules.

Screenshots (if appropriate)

Any other comments?

I have not executed tests as I have not changed the code. I simply updated a submodule with a newer version to make giotto-tda compatible with newer versions of Python.

Checklist

  • I have read the guidelines for contributing.
  • My code follows the code style of this project. I used flake8 to check my Python changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. I used pytest to check this on Python tests.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2024

CLA assistant check
All committers have signed the CLA.

@ulupo
Copy link
Collaborator

ulupo commented Mar 5, 2024

Hi @rballeba! This sounds good to me. I guess there's the CLA to sign still.

@ulupo
Copy link
Collaborator

ulupo commented Mar 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rballeba
Copy link
Contributor Author

rballeba commented Mar 5, 2024

Thank you @ulupo ^^. I think it could be also useful to allow Python 3.11 formally. I would not care to keep working on this project in my free times. If you want, I can try to do it in some weeks.

@ulupo
Copy link
Collaborator

ulupo commented Mar 5, 2024

You are right @rballeba! The truth is, I have almost no bandwidth to keep being the main maintainer for this project, as I have moved to a different field. If you care for it, I am happy to help.

I would not care to keep working on this project in my free times. If you want, I can try to do it in some weeks.

Just to check that you really mean "you would not care"? :)

@rballeba
Copy link
Contributor Author

rballeba commented Mar 5, 2024

@ulupo I mean, I would love to help with the project :)

Copy link
Collaborator

@ulupo ulupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tests fail, but it doesn't seem to have to do with your changes.

@ulupo ulupo merged commit dd50a58 into giotto-ai:master Mar 5, 2024
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants