-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pybind11 #689
Updating pybind11 #689
Conversation
Hi @rballeba! This sounds good to me. I guess there's the CLA to sign still. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thank you @ulupo ^^. I think it could be also useful to allow Python 3.11 formally. I would not care to keep working on this project in my free times. If you want, I can try to do it in some weeks. |
You are right @rballeba! The truth is, I have almost no bandwidth to keep being the main maintainer for this project, as I have moved to a different field. If you care for it, I am happy to help.
Just to check that you really mean "you would not care"? :) |
@ulupo I mean, I would love to help with the project :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Tests fail, but it doesn't seem to have to do with your changes.
Reference issues/PRs
Types of changes
Description
Updating pybind submodules.
Screenshots (if appropriate)
Any other comments?
I have not executed tests as I have not changed the code. I simply updated a submodule with a newer version to make giotto-tda compatible with newer versions of Python.
Checklist
flake8
to check my Python changes.pytest
to check this on Python tests.