Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Template] -enablepaket flag #130

Closed
ghost opened this issue Nov 4, 2017 · 8 comments
Closed

[Template] -enablepaket flag #130

ghost opened this issue Nov 4, 2017 · 8 comments
Labels
feature request Request to add new functionality help wanted Community contribution or any kind of help much appreciated PR approved A PR for this issue will get accepted (as long as inline with the comms)

Comments

@ghost
Copy link

ghost commented Nov 4, 2017

I'm working on the template project to add the flag -enablepaket 'cause paket is nice 💪

I'm using custom operations in order to use conditionals on .fsproj:

<!-- if(enablepaket) -->
  <Import Project="..\..\.paket\Paket.Restore.targets" />
  <!-- else -->
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Cors" Version="2.0.*" />

it's not working by now, always get the conditional comments on fsproj... but what do you think 👍 👎?

@forki
Copy link
Contributor

forki commented Nov 5, 2017 via email

@dustinmoris
Copy link
Member

Hi, my thoughts on this is that one project doesn't need two package managers. I think Paket is cool and if there is an easy and intuitive way to change the project to use Paket instead of NuGet then I'd be open for such a change, but making the project build with two different package managers I don't think makes sense, because at the time of a build the project doesn't care if NuGet or Paket restores the dependencies and you'd only use one package manager at a time so I don't see why to add the additional overhead of supporting two technologies when only one is ever needed?

Long answer short: Either Paket or NuGet, but not both please :)

@forki
Copy link
Contributor

forki commented Nov 6, 2017 via email

@nojaf
Copy link
Contributor

nojaf commented Nov 6, 2017

Perhaps all that is needed here is some documentation on converting to paket once you scaffolded the template. Although the paket docs pretty much cover it.

@forki
Copy link
Contributor

forki commented Nov 6, 2017 via email

@ghost
Copy link
Author

ghost commented Nov 7, 2017

@dustinmoris no, the project won't use both package managers (?), only the template will change the .fsproj to use either Paket.Restore.targets or PackageReference and include the paket.references file (if paket is enabled). I think its a minimal change, only will touch the template and benefit the users who prefer paket :)

@dustinmoris
Copy link
Member

I see... yeah makes sense to give users the choice for the template!

@dustinmoris dustinmoris added feature request Request to add new functionality PR approved A PR for this issue will get accepted (as long as inline with the comms) labels Nov 13, 2017
@dustinmoris dustinmoris added the help wanted Community contribution or any kind of help much appreciated label Dec 3, 2017
@dustinmoris
Copy link
Member

I moved this issue to the giraffe-template repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request to add new functionality help wanted Community contribution or any kind of help much appreciated PR approved A PR for this issue will get accepted (as long as inline with the comms)
Projects
None yet
Development

No branches or pull requests

3 participants