TokenRouter #114
Merged
TokenRouter #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the quick changes! I'll merge this PR for now as it looks good and as I said before the next time I'll get time to pick things up will be Sat/Sun this week. Gives you time to do any more tweaks and then I can create another release with the TokenRouter feature and even start thinking about a first RC release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from the previous PR I closed due to metadata being messed with, please see updates in line with updates requested, happy to go over any last bits.
I separated the routers parsers out into a separate file to reduce clutter.
I amended
blah blahtest to what I expect and now passing but let me know if the url encoding inside unit testing is an issue.