Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the Ansible module to run in Python3 #2449

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Allow the Ansible module to run in Python3 #2449

merged 1 commit into from
Oct 30, 2017

Conversation

brianhelba
Copy link
Member

No description provided.

@brianhelba
Copy link
Member Author

I don't know whether this is the only change necessary, but this should at least allow the static analysis tests to pass in Python 3.

@brianhelba brianhelba mentioned this pull request Oct 29, 2017
Closed
12 tasks
kotfic
kotfic approved these changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@kotfic kotfic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I ran the ansible_client tests against ubuntu-16.04 with ansible_python_interpreter = python3. I did not see any python3 related issues. LGTM

@brianhelba brianhelba merged commit 5be87a9 into master Oct 30, 2017
@brianhelba brianhelba deleted the ansible-module-py3 branch October 30, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna danlamanna approved these changes

@kotfic kotfic kotfic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianhelba @danlamanna @kotfic