Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support range requests on S3 access. #2468

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@manthey
Copy link
Member

commented Nov 8, 2017

Without this, seeks don't work in a file context.

Support range requests on S3 access.
Without this, seeks don't work in a file context.

@manthey manthey requested a review from danlamanna Nov 13, 2017

@manthey

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2017

@zachmullen perhaps you'd be the best person to review this.

@zachmullen
Copy link
Member

left a comment

Code LGTM, haven't tested against actual S3 assetstore myself but if you have done so we can ship it.

@manthey

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2017

Yes, it has been tested with an actual S3 assetstore.

@manthey manthey merged commit 3f0c734 into master Nov 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90.43%)
Details
codecov/project 90.44% (+<.01%) compared to 14d5b21
Details

@manthey manthey deleted the s3-range-request branch Nov 28, 2017

@mgrauer mgrauer referenced this pull request Mar 21, 2018

Merged

v2.5.0 #2673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.