Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support range requests on S3 access. #2468

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Support range requests on S3 access. #2468

merged 1 commit into from
Nov 28, 2017

Conversation

manthey
Copy link
Member

@manthey manthey commented Nov 8, 2017

Without this, seeks don't work in a file context.

@manthey
Support range requests on S3 access.
83e56bc 
Without this, seeks don't work in a file context.
@manthey
Copy link
Member Author

manthey commented Nov 27, 2017

@zachmullen perhaps you'd be the best person to review this.

zachmullen
zachmullen approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@zachmullen zachmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, haven't tested against actual S3 assetstore myself but if you have done so we can ship it.

@manthey
Copy link
Member Author

manthey commented Nov 28, 2017

Yes, it has been tested with an actual S3 assetstore.

@manthey manthey merged commit 3f0c734 into master Nov 28, 2017
@manthey manthey deleted the s3-range-request branch November 28, 2017 14:41
@mgrauer mgrauer mentioned this pull request Mar 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmullen zachmullen zachmullen approved these changes

@danlamanna danlamanna Awaiting requested review from danlamanna

Assignees
No one assigned
Labels
bug domain: s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manthey @zachmullen