Add an environment variable to configure the npm path #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this an envvar but other options are passed as args? |
|
Because @brianhelba suggested it. I think it does make sense; this kind of thing is often done via env variables, but I don't have a strong opinion. |
This replaces the old `--npm` flag that was omitted in the new build implementation.
jbeezley
force-pushed
the
npm-command-path
branch
from
61b6075
to
f31b3b7
Compare
|
Can we expose it as both? |
zachmullen
reviewed
Oct 5, 2018
|
Can we add a try except with a bit more of a helpful error message? I totally missed the npm flag the first time I was playing with installing girder on windows. |
|
I added a usage error that states Does that error not trigger for you or are you saying the message is unclear? |
zachmullen
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the old
--npmflag that was omitted in the new build implementation.