fix signals being ignored (#113) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when running the Valhalla service with e.g.:
$ docker run -v $PWD/data:/data ghcr.io/gis-ops/docker-valhalla/valhalla
...
INFO: Found config file. Starting valhalla service!
....
You couldn't stop it with Ctrl+C (SIGINT) or `kill $!` (SIGTERM) when
run in the background, because the run.sh shell script didn't use `exec`
for the `valhalla_service` command, which resulted in an intermediary
shell process (that didn't pass the signals to child processes because
Docker gives it PID 1, which is special[1]). This is a well-known
pitfall of Docker ENTRYPOINT shell scripts.[2][3]
This commit fixes that oversight.
Sidenote: It still takes ~30 seconds for a SIGTERM to shutdown
the server because valhalla_service has configured such a graceful
shutdown period for the prime_server HTTP server.
[1]: https://docs.docker.com/engine/reference/builder/#entrypoint
[2]: https://hynek.me/articles/docker-signals/
[3]: https://petermalmgren.com/signal-handling-docker/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when running the Valhalla service with e.g.:
You couldn't stop it with Ctrl+C (SIGINT) or
kill $!(SIGTERM) when run in the background, because the run.sh shell script didn't useexecfor thevalhalla_servicecommand, which resulted in an intermediary shell process (that didn't pass the signals to child processes because Docker gives it PID 1, which is special1). This is a well-known pitfall of Docker ENTRYPOINT shell scripts.2This commit fixes that oversight.
Sidenote: It still takes ~30 seconds for a SIGTERM to shutdown the server because valhalla_service has configured such a graceful shutdown period for the prime_server HTTP server.